ref(onboarding): Consolidate Manual button in integrations #77795
+191
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
priscilawebdev
changed the title
…ttons-instrumentation-code
Bundle ReportChanges will increase total bundle size by 29.24MB (100.0%) ⬆️
|
priscilawebdev
commented
Sep 20, 2024
| import {getInstallConfig, getSdkInitSnippet} from 'sentry/utils/gettingStartedDocs/node'; | ||
|
|
||
| type Params = DocsParams; | ||
| export enum InstallationMode { |
There was a problem hiding this comment.
I find this repetition very verbose and have the feeling we could make it more reusable 🤔
| * Used to show the installation mode for certain platforms, e.g. manual or auto. | ||
| * This is defined inside of a platform file | ||
| */ | ||
| installationMode: string; |
There was a problem hiding this comment.
more refactoring is needed, I would like to get this from the hook useLoadGettingStarted but added this here for now.
| @@ -31,6 +36,7 @@ export function useOnboardingQueryParams(): [ | |||
| product: decodeList, | |||
| showLoader: decodeBoolean, | |||
| showManualSetup: decodeBoolean, | |||
| installationMode: decodeScalar, | |||
There was a problem hiding this comment.
also it would be better to return MANUAL or AUTO from an enum but I did not want to add a custom decode here now
Comment on lines
+180
to
+189
| if (!docsConfig || !dsn || !projectKeyId) { | ||
| return ( | ||
| <LoadingError | ||
| message={t( | ||
| 'The getting started documentation for this platform is currently unavailable.' | ||
| )} | ||
| onRetry={refetch} | ||
| /> | ||
| ); | ||
| } |
There was a problem hiding this comment.
In the future, we might consider moving this to the parent component, as we currently have the same check within SdkDocumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-09-20.at.14.41.59.mov
closes #77538